Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Fix: Preserve Whitespace for Tag Values Resembling "null" to Prevent ARM Assignment Errors #8121 #8122

Open
wants to merge 1 commit into
base: release-1.28
Choose a base branch
from

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jan 23, 2025

This is an automated cherry-pick of #8119

/king bug

Tags with values resembling "null" (e.g., " null " or " NuLL ") will now retain their leading and trailing whitespace during inheritance or updates to avoid errors caused by ARM's reserved tag value "null". 
This change only affects tags with such specific values, ensuring all other tags continue to have whitespace trimmed as before.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2025
@nilo19 nilo19 changed the title [release-1.29] Fix: Preserve Whitespace for Tag Values Resembling "null" to Prevent ARM Assignment Errors #8121 [release-1.28] Fix: Preserve Whitespace for Tag Values Resembling "null" to Prevent ARM Assignment Errors #8121 Jan 23, 2025
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 23, 2025

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 23, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

@nilo19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-capz-1-28 b3d0f77 link true /test pull-cloud-provider-azure-e2e-ccm-capz-1-28
pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz-1-28 b3d0f77 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz-1-28
pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-28 b3d0f77 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-28
pull-cloud-provider-azure-e2e-capz-1-28 b3d0f77 link true /test pull-cloud-provider-azure-e2e-capz-1-28
pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-28 b3d0f77 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-28

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants