Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add values.schema.json #2286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ElijahQuinones
Copy link
Member

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

This PR adds the values.schema.json file. Allowing us to make sure changes to helm chart parameters also appear in the eks add-on version of the driver as long as it makes sense to do so.

How was this change tested?

❯ helm lint .
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

Does this PR introduce a user-facing change?

Add values.schema.json to validate changes in values.yaml make it to the add-on schema.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ConnorJC3 January 9, 2025 22:06
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from torredil January 9, 2025 22:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from elijahquinones. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Code Coverage Diff

This PR does not change the code coverage

@k8s-ci-robot
Copy link
Contributor

@ElijahQuinones: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-external-test-arm64 8fd4a86 link false /test pull-aws-ebs-csi-driver-external-test-arm64
pull-aws-ebs-csi-driver-e2e-multi-az 8fd4a86 link true /test pull-aws-ebs-csi-driver-e2e-multi-az
pull-aws-ebs-csi-driver-e2e-single-az 8fd4a86 link true /test pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-external-test 8fd4a86 link true /test pull-aws-ebs-csi-driver-external-test
pull-aws-ebs-csi-driver-external-test-eks 8fd4a86 link true /test pull-aws-ebs-csi-driver-external-test-eks
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows 8fd4a86 link true /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants