-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the wrong error return value #1279
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: rustco <[email protected]>
The committers listed above are authorized under a signed CLA. |
Welcome @rustco! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rustco The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rustco. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed |
Thanks @rustco, your change looks good, but can you explain a little more about the actual failure you have seen without this? The Release Note could express a little more details too, replace the CAPITALIZED phrases 😃
|
What type of PR is this?
What this PR does / why we need it:
fix the wrong error return value
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: