Serve metrics & pprof via CSIMetricsManager #1347
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We recently updated csi-lib-utils to serve additional registries via PR kubernetes-csi/csi-lib-utils#189 so that all sidecars can easily serve leader, work queue, process, and Go runtime metrics via Kubernetes legacymetrics.
This PR refactors the provisioner to
Tested:
See gist: https://gist.github.com/AndrewSirenko/2d3bcd1cbc47541cab4f4fae9561fec0
Built all sidecar, deployed alongside EBS CSI Driver v1.40. Saw new metrics when scraping each sidecar /metrics endpoint.
Also tested upgrade case: No errors when upgrading EBS CSI Driver via helm from revision with default sidecars to these custom sidecars.
Excercised dynamic provisioning, snapshot, resize, and modify workflows. No errors. Workqueue metrics increased.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: