-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated external-snapshot-metadata sidecar support to its alpha level #595
base: master
Are you sure you want to change the base?
Updated external-snapshot-metadata sidecar support to its alpha level #595
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlbraganza The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alpha release of the external snapshot metadata sidecar.
7097bcd
to
3963162
Compare
deploy/kubernetes-1.30/hostpath/csi-snapshot-metadata-sidecar.patch
Outdated
Show resolved
Hide resolved
``` | ||
|
||
This client performs following actions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think its a good idea to summarize actions performed by the client behind the scene to give more clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It made a lot of sense before but now it repeats what is present in the external-snapshot-metadata repo and the documentation.
Co-authored-by: Prasad Ghangal <[email protected]>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #594
Special notes for your reviewer:
Does this PR introduce a user-facing change?: