Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Helm Chart from Static Manifests #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hswong3i
Copy link
Contributor

@hswong3i hswong3i commented Mar 24, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR convert our static deployment manifests from deploy/kubernetes-latest/* into Helm Charts under charts/*, by running a convert script under deploy/util/chart-releaser.sh.

Moreover, it handle the chart release with branch gh-pages, by integrate with https://github.com/helm/chart-releaser-action.

The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-csi-driver-host-path/index.yaml, by:

helm repo add csi-driver-host-path https://alvistack.github.io/kubernetes-csi-csi-driver-host-path/
helm repo update
helm search repo csi-driver-host-path

Before each stable tag release, maintainers only required to:

  1. Run the ./deploy/kubernetes-latest/chart-releaser.sh and update templates under charts/*/templates/*
  2. Double confirm charts/*/values.yml with correct values, e.g. image tags
  3. git add --all --force charts/* && git commit
Create Helm Chart from Static Manifests

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hswong3i
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from carlory and gnufied March 24, 2025 14:26
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @hswong3i. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 24, 2025
@hswong3i hswong3i force-pushed the master branch 3 times, most recently from 418bad9 to 139810d Compare March 25, 2025 07:58
**What type of PR is this?**
/kind feature

**What this PR does / why we need it**:
This PR convert our static deployment manifests from `deploy/kubernetes-latest/*` into Helm Charts under `charts/*`, by running a convert script under `deploy/util/chart-releaser.sh`.

Moreover, it handle the chart release with branch `gh-pages`, by integrate with https://github.com/helm/chart-releaser-action.

The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-csi-driver-host-path/index.yaml, by:

    helm repo add csi-driver-host-path https://alvistack.github.io/kubernetes-csi-csi-driver-host-path/
    helm repo update
    helm search repo csi-driver-host-path

Before each stable tag release, maintainers only required to:
1. Run the `./deploy/kubernetes-latest/chart-releaser.sh` and update templates under `charts/*/templates/*`
2. Double confirm `charts/*/values.yml` with correct values, e.g. image tags
3. `git add --all --force charts/* && git commit`

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants