Skip to content

fix(object): properly serialize objects on create/replace/patch #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(object): properly serialize objects on create/replace/patch #2400

wants to merge 1 commit into from

Conversation

schrodit
Copy link
Contributor

Fixes #2396

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: schrodit
Once this PR has been reviewed and has the lgtm label, please assign mstruebing for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2025
@schrodit
Copy link
Contributor Author

/assign mstruebing

@cjihrig
Copy link
Contributor

cjihrig commented Apr 29, 2025

Can you add tests please.

@brendandburns
Copy link
Contributor

Thanks for the PR +1 for unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgamero davidgamero Awaiting requested review from davidgamero

@mstruebing mstruebing Awaiting requested review from mstruebing

Assignees

@mstruebing mstruebing

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkPolicy.spec.ingress.from is not correctly serialized
5 participants
@schrodit @k8s-ci-robot @cjihrig @brendandburns @mstruebing