Repository navigation
LimitRange default field missing #855
Description
When creating a LimitRange I found out that this wouldn't work as expected
const lr_config = {
apiVersion: 'v1',
kind: 'LimitRange',
metadata: {
name: 'default',
},
spec: {
limits: [
{
type: 'Container',
default: {
cpu: '200m',
memory: '800Mi',
},
defaultRequest: {
cpu: '200m',
memory: '800Mi',
},
},
],
},
};
k8sApi_core.createNamespacedLimitRange("default", lr_config);In fact the resource was deployed in the cluster without the field "default"
apiVersion: v1
kind: LimitRange
metadata:
creationTimestamp: ***
name: default
namespace: default
resourceVersion: ***
uid: ***
spec:
limits:
- defaultRequest:
cpu: 200m
memory: 800Mi
type: Container
Digging the source code I managed to track the issue to this file
The solution for me was to replace "deafult" with "_default" as follows:
const lr_config = {
apiVersion: 'v1',
kind: 'LimitRange',
...
spec: {
limits: [
{
type: 'Container',
_default: {
cpu: '200m',
memory: '800Mi',
},
...
},
],
},
};
k8sApi_core.createNamespacedLimitRange("default", lr_config);If not possible to use the expected field name I think we should make it clear in the documentation for clarity sake
Activity
brendandburns commentedon Aug 12, 2022
This is happening because
defaultis a reserved word in Javascript. In this specific context (embedded field name) it is ok to use, but it appears that the code generator is not sophisticated enough to understand that nuance.I agree that it is subtle and confusing to an end-user, we should add this to a 'gotchas' section of the documentation.
It may be possible to fix this in the upstream code generator (https://github.com/OpenAPITools/openapi-generator) but I'm not sure if it is worth the effort, especially given that we are in the (slow) process of switching generators.
k8s-triage-robot commentedon Nov 10, 2022
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/staleis appliedlifecycle/stalewas applied,lifecycle/rottenis appliedlifecycle/rottenwas applied, the issue is closedYou can:
/remove-lifecycle stale/lifecycle rotten/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
k8s-triage-robot commentedon Dec 10, 2022
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/staleis appliedlifecycle/stalewas applied,lifecycle/rottenis appliedlifecycle/rottenwas applied, the issue is closedYou can:
/remove-lifecycle rotten/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
brendandburns commentedon Dec 16, 2022
/lifecycle freeze