-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: add missing continue token when build cluster list call #3930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @cyrilcsr! |
Looks good. It would be great to add unit tests so that we don't regress in the future. |
I have added a few unit tests for building list call. I'm not sure which test file should I put these unit tests, so I created a new GenericKubernetesListApiTest file which refers to the GenericKubernetesGetApiTest file. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyrilcsr, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, there
This pr fixes missing continue token when listing resources without namespace specified. This will cause when passing continue token, we always get the result of first page. Seems in makeClusterListCallBuilder() the continue param from ListOptions is never used.