docs: Add info about static build #281
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Jeansen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -14,7 +14,7 @@ git clone https://github.com/kubernetes-client/c | |||
| CLIENT_REPO_ROOT=${PWD}/c | |||
|
|
|||
| # Install pre-requisites | |||
| sudo apt-get install libssl-dev libcurl4-openssl-dev libwebsockets-dev uncrustify | |||
| sudo apt-get install libssl-dev libcurl4-openssl-dev libwebsockets-dev uncrustify cmake g++ | |||
There was a problem hiding this comment.
A small suggestion: Since the client library is written for C programming, not just C++, it would be better to remove the g++ dependency.
Since this PR has already been merged, we may need another PR to remove it.
Sorry for the delay in my review.
There was a problem hiding this comment.
I took this dependency from the devcontainer in this project. g++ is needed when you want to build libyaml, which is a dependency for this client. So it is kind of a pre-requisite, is it not?
There was a problem hiding this comment.
Oh, I see.
I don't think g++ is a required dependency for building libyaml. (build-essential is sufficient) The purpose of including this dependency in the devcontainer is just to provide users with a container development/testing environment. We could use build-essential instead.
However, the README.md is where developers/users will find relevant information. I'm concerned that the g++ dependency might mislead them into thinking this is a project that requires a C++ compiler.
There was a problem hiding this comment.
Looks like you are right. I'll make a PR where g++ is removed, then.
The latest changes from openapi-generator have been merged, including OpenAPITools/openapi-generator#21635. This PR amends the README accordingly.