Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: respect named ports of restartable init containers #4994

Merged
merged 1 commit into from
Feb 17, 2025
Merged

controller: respect named ports of restartable init containers #4994

merged 1 commit into from
Feb 17, 2025

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@coveralls
Copy link

coveralls commented Feb 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13361440934

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 22.041%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/pod.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/pod.go 1 0.0%
Totals Coverage Status
Change from base Build 13333346792: -0.003%
Covered Lines: 10246
Relevant Lines: 46487
💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review February 15, 2025 06:26
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 15, 2025
oilbeater
oilbeater requested changes Feb 17, 2025
View reviewed changes
pkg/controller/pod.go Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 17, 2025
@zhangzujian zhangzujian force-pushed the netpol-restartable-init-container branch from 39dc1a7 to b05bc61 Compare February 17, 2025 02:13
@zhangzujian zhangzujian merged commit f9904d2 into kubeovn:master Feb 17, 2025
71 of 72 checks passed
@zhangzujian zhangzujian deleted the netpol-restartable-init-container branch February 17, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

@changluyi changluyi changluyi approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer network policy size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangzujian @coveralls @oilbeater @changluyi