fix security groups changed when vm is shut down #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13276309715Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
dosubot
bot
added
size:M
zhangzujian
reviewed
Feb 10, 2025
zhaocongqi
force-pushed
the
fix-vm-sg
branch
from
e0ff2a0 to
126152c
Compare
zbb88888
approved these changes
Feb 10, 2025
zhangzujian
reviewed
Feb 11, 2025
zhangzujian
reviewed
Feb 11, 2025
zhangzujian
approved these changes
Feb 12, 2025
Signed-off-by: zhaocongqi <[email protected]>
Signed-off-by: zhaocongqi <[email protected]>
Signed-off-by: zhaocongqi <[email protected]>
zhaocongqi
force-pushed
the
fix-vm-sg
branch
from
126152c to
12c28dd
Compare
zbb88888
pushed a commit
that referenced
this pull request
Feb 13, 2025
* fix security groups changed when vm is closed * add unit test for UnionStringSlice Signed-off-by: zhaocongqi <[email protected]> --------- Signed-off-by: zhaocongqi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4975