-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: remove duplicate default-allow-same-namespace network policy #12492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove duplicate default-allow-same-namespace network policy #12492
Conversation
|
Skipping CI for Draft Pull Request. |
hbelmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Thank you, otherwise I have KFP 2.5.1 already successfully in kubeflow platform / manifests. It is a great release. It did clash with https://github.com/kubeflow/manifests/blob/master/common/networkpolicies/base/default-allow-same-namespace.yaml |
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
676aa00 to
c7224cc
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droctothorpe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This PR removes
allow-same-namespace-networkpolicy.yaml, because it creates duplication in manifests repo and should only exist in KFP test manifestsSynchronize kubeflow pipelines manifests 2.15.0 manifests#3283 (comment)