Skip to content

Conversation

@akagami-harsh
Copy link
Contributor

@akagami-harsh akagami-harsh commented Nov 26, 2025

Description of your changes:

This PR removes allow-same-namespace-networkpolicy.yaml, because it creates duplication in manifests repo and should only exist in KFP test manifests

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akagami-harsh
Copy link
Contributor Author

cc @juliusvonkohout

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@juliusvonkohout
Copy link
Member

Thank you, otherwise I have KFP 2.5.1 already successfully in kubeflow platform / manifests. It is a great release. It did clash with https://github.com/kubeflow/manifests/blob/master/common/networkpolicies/base/default-allow-same-namespace.yaml
CC @droctothorpe @akagami-harsh for approval.

@droctothorpe
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droctothorpe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9a337a9 into kubeflow:master Dec 1, 2025
177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants