Skip to content

feat: Hide entities with hidden flag on Workspace create #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from
Open

feat: Hide entities with hidden flag on Workspace create #581

wants to merge 1 commit into from

Conversation

thaorell
Copy link

@thaorell thaorell commented Sep 9, 2025

closes: #579

Description:

  • Hide items that are have hidden: true property
  • Fix mocked objects for testing purposes

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Sep 9, 2025
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Sep 9, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/v2 area - version - kubeflow notebooks v2 label Sep 9, 2025
@paulovmr
Copy link

/ok-to-test

paulovmr
paulovmr suggested changes Sep 10, 2025
View reviewed changes
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thaorell , thanks for the PR, just one small comment

@thaorell thaorell changed the title feat: Hide entities with hidden flag feat: Hide entities with hidden flag on Workspace create Sep 10, 2025
paulovmr
paulovmr approved these changes Sep 11, 2025
View reviewed changes
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederign ederign Awaiting requested review from ederign

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

@caponetto caponetto Awaiting requested review from caponetto

1 more reviewer

@paulovmr paulovmr paulovmr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@paulovmr paulovmr

Labels
area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/L
Projects
Kubeflow Notebooks
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaorell @paulovmr @caponetto