fix: update supported platforms for multi-arch builds #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion with the Kubeflow WG lead - concerns were raised about including `linux/s390x` support in our multi-arch builds for the following reasons: - not clear we could in good faith support this system due to lack of hardware / potential emulation issues - not clear there is enough of a need from community to support `linux/s390x` for Kubeflow Notebooks. As a result - we are going to remove the `linux/s390x` target from our multi-arch builds logic. Additionally, included a minor fix to explicitly specify the `v8` variant of `linux/arm64`. Today `linux/arm64` and `linux/arm64/v8` are essentially the same - but that could change if there was ever a `v9` variant introduced. As such - opting to be explicit here. Signed-off-by: Andy Stoneberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
the
area/controller
google-oss-prow
bot
added
area/frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ NO GH ISSUE
After discussion with the Kubeflow WG lead - concerns were raised about including
linux/s390xsupport in our multi-arch builds for the following reasons:linux/s390xfor Kubeflow Notebooks.As a result - we are going to remove the
linux/s390xtarget from our multi-arch builds logic for all theworkspacescomponents.Additionally, included a minor fix to explicitly specify the
v8variant oflinux/arm64. Todaylinux/arm64andlinux/arm64/v8are essentially the same - but that could change if there was ever av9variant introduced. As such - opting to be explicit here.