fix(nb): fixed function to get notebook status from container state #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Marcotte <[email protected]>
Signed-off-by: Mathis Marcotte <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area v1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the function get_status_from_container_state found in status.go under crud-web-apps/jupyter/backend had an issue in how one conditional was written.
It was doing a comparison between an array of a string with a completely different string, which will always result as false.
Tracked down where this issue was introduced to kubeflow/kubeflow#7585
Additionally, I noticed that this exact test case was defined in status_test.go. But it seems like the test case was built from the broken code, because the assertion did not follow the logic of the function.
Original PR here: kubeflow/kubeflow#7716