Skip to content

Conversation

mathis-marcotte
Copy link

I noticed that the "delete_pvc" endpoint was referencing a missing value from the "viewer_utils" import.

When running that code, it would result in this error:

Traceback (most recent call last):
  File "/home/marcoma/Documents/upstreams/kubeflow/components/crud-web-apps/volumes/backend/web-apps-dev/lib/python3.10/site-packages/flask/app.py", line 917, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/marcoma/Documents/upstreams/kubeflow/components/crud-web-apps/volumes/backend/web-apps-dev/lib/python3.10/site-packages/flask/app.py", line 902, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
  File "/home/marcoma/Documents/upstreams/kubeflow/components/crud-web-apps/volumes/backend/apps/default/routes/delete.py", line 30, in delete_pvc
    viewer_utils.VIEWER_LABEL,
AttributeError: module 'apps.common.viewer' has no attribute 'VIEWER_LABEL'

So I replaced it for a value that does exist. Please confirm if this was the original intent for this warning log.

Original PR here: kubeflow/kubeflow#7718

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mathis-marcotte mathis-marcotte changed the title fix(volumes backend): fixed missing reference in crud-web-apps volumes backend fix(nb): fixed missing reference in crud-web-apps volumes backend Sep 5, 2025
@andyatmiami
Copy link
Contributor

/area v1

@google-oss-prow google-oss-prow bot added the area/v1 area - version - kubeflow notebooks v1 label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v1 area - version - kubeflow notebooks v1 size/XS
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants