Skip to content

Work around Security Framework failing to import PKCS12 from OpenSSL 3 #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Work around Security Framework failing to import PKCS12 from OpenSSL 3 #693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25ac492
Work around Security Framework failing to import PKCS12 from OpenSSL 3
kazk Nov 5, 2021
fcf3a9e
Try `PBE_WITHSHA1AND3_KEY_TRIPLEDES_CBC` for cert algorithm
kazk Nov 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion kube-client/src/client/tls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,23 @@ pub mod native_tls {
// TODO These are all treated as the same error. Add specific errors.
let x509 = X509::from_pem(pem).map_err(Error::OpensslError)?;
let pkey = PKey::private_key_from_pem(pem).map_err(Error::OpensslError)?;
let p12 = Pkcs12::builder()
#[cfg(not(any(target_os = "macos", target_os = "ios")))]
let p12_builder = Pkcs12::builder();
#[cfg(any(target_os = "macos", target_os = "ios"))]
let p12_builder = {
use openssl::nid::Nid;
// OpenSSL 3 uses `Nid::AES_256_CBC` by default, but Security Framework used by
// `native_tls` on macOS/iOS fails to import it.
// Work around by using the legacy algorithm.
// https://openradar.appspot.com/FB8988319
// https://github.com/kube-rs/kube-rs/issues/691
let mut builder = Pkcs12::builder();
builder
.key_algorithm(Nid::PBE_WITHSHA1AND3_KEY_TRIPLEDES_CBC)
.cert_algorithm(Nid::PBE_WITHSHA1AND3_KEY_TRIPLEDES_CBC);
builder
};
let p12 = p12_builder
.build(password, "kubeconfig", &pkey, &x509)
.map_err(Error::OpensslError)?;
let der = p12.to_der().map_err(Error::OpensslError)?;
Expand Down