Do not emit additionalPrinterColumns, categories, shortNames when empty #1751
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Berktold <[email protected]>
JanBerktold
force-pushed
the
ignore-empty-vecs
branch
from
9166c8a to
b1e96eb
Compare
|
Hey thanks for tackling this. Found the open issue associated with it. It seems to err on the crd_enum_test example, might be worth looking at. (Lint and deny should be unrelated, i'll look at those in a separate PR). |
|
FYI, we're also seeing this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are using ArgoCD to deploy our
kube-generated CRDs into our K8s clusters. ArgoCD always considers the resources as out of sync as the empty arrays are omitted in the response from the server.Solution
For the relevant fields, only set them in the Values object if the vectors are non-empty. This certainly isn't the prettiest solution, but I couldn't find a good way to include it in the original
serde_json::json!invocation since it doesn't seem to support conditionals. Suggestions are very welcome!