Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing update for outputs #158

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix: missing update for outputs #158

merged 2 commits into from
Mar 31, 2025

Conversation

csatib02
Copy link
Member

No description provided.

@csatib02 csatib02 added the bug Something isn't working label Mar 28, 2025
@csatib02 csatib02 requested review from pepov, OverOrion and Copilot March 28, 2025 12:56
@csatib02 csatib02 self-assigned this Mar 28, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a missing update for outputs by refining error messages and adding new state update logic, while also reorganizing the demo manifests for loki.

  • Updated error messages and state transitions in tenant resource management
  • Reorganized and redefined loki outputs and subscriptions in the demo manifests

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/resources/manager/tenant_resource_manager.go Revised error messages and added state update logic for outputs
docs/demos/loki/manifests.yaml Reorganized and redefined subscription and output definitions for demos
Files not reviewed (1)
  • docs/demos/loki/setup.sh: Language not supported
Comments suppressed due to low confidence (2)

pkg/resources/manager/tenant_resource_manager.go:129

  • Consider reviewing the phrasing of this error message to ensure consistency with similar log messages elsewhere in the code, which improves clarity during debugging.
t.Logger.Error(updateErr, fmt.Sprintf("failed to update resource (%s/%s) -> tenant (%s) reference", res.GetNamespace(), res.GetName(), tenantName))

docs/demos/loki/manifests.yaml:81

  • Verify that the reordering and removal of manifest blocks in this file are intentional and do not disrupt any implicit dependencies in the deployment configuration.
apiVersion: telemetry.kube-logging.dev/v1alpha1

@csatib02 csatib02 merged commit d2ebdcf into main Mar 31, 2025
11 checks passed
@csatib02 csatib02 deleted the fix/output-status branch March 31, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants