Skip to content

Conversation

@Jan200101
Copy link
Contributor

No description provided.

@ktwrd ktwrd changed the base branch from main to develop June 7, 2024 01:10
@ktwrd ktwrd added this to the v1.4.0 milestone Jun 7, 2024
@ktwrd ktwrd added the enhancement New feature or request label Jun 7, 2024
@Jan200101 Jan200101 force-pushed the PR/linux-better-sourcemod-detection branch from 667a9b2 to 0351119 Compare June 7, 2024 18:24
@ktwrd ktwrd modified the milestones: v1.4.0, v1.5.0 Jun 10, 2024
@ktwrd ktwrd removed this from the v1.5.0 milestone Jul 1, 2024
@ktwrd ktwrd self-requested a review July 1, 2024 05:48
}
}
},
Err(_) => {},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should return (or at least log) that error

...
Err(e) => {
    warn!("[find_sourcemod_path] failed to parse vdf content {:#?}", e);
}
...

Or

...
// src/helper/linux.rs
Err(e) => {
    return Err(BeansError::VdfParseFailure {
		error: e,
		content: vdf_content.clone()
	});
}
...
// src/error.rs
pub enum BeansError {
...
    #[error("Failed to parse VDF File {:error}")]
    VdfParseFailure {
        error: <the error type that Vdf::parse provides>
        content: String
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants