Add sGoalKeeping #17
Open
Add sGoalKeeping #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
americast
commented
May 17, 2017
scripts/skills/sGoalKeeping.py
Outdated
| if state.homeDetected[i]: | ||
| obs.append(Obstacle(bot.x, bot.y, 0, 0, 2*BOT_RADIUS)) | ||
|
|
||
| for i in xrange (len(state.homeDetected), len(state.homeDetected) + len(state.awayDetected)): |
There was a problem hiding this comment.
I guess this part needs some discussion.
There was a problem hiding this comment.
I think this is what you are looking for :
for j in range(0,len(state.awayDetected)):
if state.awayDetected[j]:
o = Obstacle()
o.x=state.awayPos[j].x
o.y=state.awayPos[j].y
o.radius=3.3*BOT_RADIUS
obs.push_back(o)
kvmanohar22
reviewed
May 19, 2017
scripts/skills/sGoalKeeping.py
Outdated
|
|
||
|
|
||
| for i,bot in enumerate(state.homePos): | ||
| if state.homeDetected[i]: |
There was a problem hiding this comment.
You should not treat bot_id itself as obstacle. Change the condition from
if state.homeDetected[i]: to
if state.homeDetected[i] and i != botID:
scripts/skills/sGoalKeeping.py
Outdated
| if(rot_theta < 45): | ||
| v_t = -rot_theta / 10 | ||
| else: | ||
| v_t = -4.5 |
There was a problem hiding this comment.
Correct the indentation here
|
@kvmanohar22 Incorporated changes requested! Thanx! |
|
@MayankB11 Please run the build for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sGoalKeeping has been added. Python equivalent for
goToPointFast()(line 37) has not been found.