Fixes various test, pre-commit issues after fixing testing workflow #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.data.network.string became .stringprot
…e in v1.7.5 release
for more information, see https://pre-commit.ci
falquaddoomi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes to issues that may have accumulated while the testing workflow was broken; the testing workflow was recently fixed in PR #500.
Most of the changes in this PR relate to two OBNB modules shadowing builtins:
obnb.typingshadowed builtintypingmodule, and was changed toobnb.alltypesobnb.data.network.stringshadowed builtinstringmodule, and was changed toobnb.data.network.stringprotAnother minor flake8 issue in
obnb.ext.orbital_featureswas also resolved; the tool recommended switching a dict comprehension that filled a dict with zeroes to use thedict.fromkeys()function, which is a more efficient way to achieve the same thing. (Unfortunately, that change ended up being included in the large refactor commit mentioned above.)