Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python package version #53

Merged
merged 3 commits into from
Nov 19, 2024
Merged

update python package version #53

merged 3 commits into from
Nov 19, 2024

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Nov 19, 2024

  • update python package to latest version f306e17
  • make changes in cloud funcs and frontend as needed
  • remove testbed button from homepage

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for gene-plexus ready!

Name Link
🔨 Latest commit 7009492
🔍 Latest deploy log https://app.netlify.com/sites/gene-plexus/deploys/673cf5498b5bf10008411204
😎 Deploy Preview https://deploy-preview-53--gene-plexus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti
Copy link
Collaborator Author

@ChristopherMancuso Not sure if any of the comment verbage in /frontend/src/api/types.ts could be updated to match the change from _tst to _res.

@ChristopherMancuso
Copy link
Contributor

@vincerubinetti I pulled this branched and tested the web server to see if it ran after running run_local.sh and it worked for me. I tried to run it on the netlfy preview and it didn't work. I can't remember what netlfy is doing and I think that is expected, but thought I would mention it

@ChristopherMancuso
Copy link
Contributor

ChristopherMancuso commented Nov 19, 2024

In /frontend/src/api/types.ts I think line 63 is the only on that would change from sp_tst to sp_res. For that document there are some places where if we want we can be more specific like in line 21 we have it just species as we know it needs to be the input species, but that could be referred to as sp_trn. Not sure when/if that matters to anyone.

The only real difference between the python package and web server is that in the python package as user can specific a gsc_trn which is used to find negative genes for training and also a gsc_res which is the gene sets that the training model is compared to. In the web server we force this to be the same in each case (defaults to Combined now). But that is why it is just gsc on line 73.

@vincerubinetti
Copy link
Collaborator Author

I'm at an appointment right now but the Netlify thing is expected since these are breaking changes and the Netlify version of the site is using the live Google Cloud functions, the old ones, but expecting them to be the new ones.

@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Nov 19, 2024

In /frontend/src/api/types.ts I think line 63 is the only on that would change from sp_tst to sp_res. For that document there are some places where if we want we can be more specific like in line 21 we have it just species as we know it needs to be the input species, but that could be referred to as sp_trn. Not sure when/if that matters to anyone.

Okay for consistency I updated species to be sp_trn in the "check genes" / "convert genes" cloud func and frontend.

Other than that, if it seems to be working, it seems like this is good to go.

@vincerubinetti vincerubinetti merged commit fd54d8e into main Nov 19, 2024
3 checks passed
@vincerubinetti vincerubinetti deleted the update-package branch November 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants