Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce memory usage #518

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat: reduce memory usage #518

wants to merge 24 commits into from

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Mar 1, 2025

  • Change GeoDataFrame and DataFrame arguments to special objects ParquetDataTable and GeoDataTable
  • Rewrite logic in all components (for now just cast to GeoDataFrame / DataFrame)
  • Add new IntersectionJoiner based on duckdb-geography extension (with s2 cell covering) or h3 extension (with h3 cell covering).
  • Add option to not return geometry in H3Regionalizer
  • Change H3 index from str to int to reduce memory usage
  • Add option to contextualize any embedding after the fact (export ContextualCountEmbedder logic and create a new function / class)
  • Add option to embed any pre-computed count embedding with other classes

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 90.07833% with 38 lines in your changes missing coverage. Please review.

Project coverage is 91.15%. Comparing base (ef24000) to head (52338a5).

Files with missing lines Patch % Lines
srai/geodatatable.py 86.10% 36 Missing ⚠️
srai/embedders/_base.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   91.77%   91.15%   -0.63%     
==========================================
  Files          63       65       +2     
  Lines        2602     2928     +326     
==========================================
+ Hits         2388     2669     +281     
- Misses        214      259      +45     
Flag Coverage Δ
macos-13-python3.12 91.08% <90.07%> (-0.54%) ⬇️
ubuntu-latest-python3.10 91.08% <90.07%> (-0.54%) ⬇️
ubuntu-latest-python3.11 91.15% <90.07%> (-0.47%) ⬇️
ubuntu-latest-python3.12 91.08% <90.07%> (-0.54%) ⬇️
ubuntu-latest-python3.9 91.14% <90.07%> (-0.63%) ⬇️
windows-latest-python3.12 91.08% <90.07%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RaczeQ RaczeQ linked an issue Mar 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add big data workflow capabilities
1 participant