Skip to content

Updated android build.gradle #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated android build.gradle #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f37799
Updated sdk and build tools
Oct 5, 2018
c817c26
Obsolete 'compile' updated to 'implementation'
Oct 5, 2018
56c562c
getNonce Error Haldner update
Oct 8, 2018
4615a5c
Updated getCardNonce error handler
Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apply plugin: "com.android.library"

android {
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion 26
Copy link

@quinnjn quinnjn Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should be set to the latest SDK which is currently 28.

Copy link

@quinnjn quinnjn Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

August 2019: New apps are required to target API level 28 (Android 9) or higher.
November 2019: Updates to existing apps are required to target API level 28 or higher.

https://android-developers.googleblog.com/2019/03/introducing-android-q-beta.html

buildToolsVersion "27.0.3"

defaultConfig {
minSdkVersion 16
targetSdkVersion 22
targetSdkVersion 26
versionCode 1
versionName "1.0"
}
Expand All @@ -19,9 +19,9 @@ android {
}

dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.facebook.react:react-native:+"
compile 'com.braintreepayments.api:braintree:2.+'
compile 'com.braintreepayments.api:drop-in:2.+'
compile group: 'com.google.code.gson', name: 'gson', version: '2.3.1'
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation "com.facebook.react:react-native:+"
implementation 'com.braintreepayments.api:braintree:2.+'
implementation 'com.braintreepayments.api:drop-in:2.+'
implementation group: 'com.google.code.gson', name: 'gson', version: '2.3.1'
}
7 changes: 6 additions & 1 deletion ios/RCTBraintree/RCTBraintree.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,13 @@ - (instancetype)init
if ( error == nil ) {
args = @[[NSNull null], tokenizedCard.nonce];
} else {
NSMutableDictionary *userInfo = [error.userInfo mutableCopy];

[userInfo removeObjectForKey:@"com.braintreepayments.BTHTTPJSONResponseBodyKey"];
[userInfo removeObjectForKey:@"com.braintreepayments.BTHTTPURLResponseKey"];

NSError *serialisationErr;
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:[error userInfo]
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:userInfo
options:NSJSONWritingPrettyPrinted
error:&serialisationErr];

Expand Down