Repository navigation
Add missing tests to verify behaviour when either old, new, or both strings are empty - #714
Merged
Merged
Conversation
…trings are empty (The behaviour in the case where you diff empty vs empty was, in particular, worth having documented by a test, to avoid inadvertently changing it, and previously no such test existed.)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused tests capture existing behavior, and no unresolved issues were identified.
0 open findings
What changed in this PR
Adds regression tests documenting character-diff behavior with empty strings, without changing implementation.
Changes:
- Verifies insertion-only and deletion-only results when one input is empty.
- Confirms that two empty inputs produce an empty change list.
| File | Description |
|---|---|
| test/diff/character.js | Adds three empty-input regression tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(The behaviour in the case where you diff empty vs empty was, in particular, worth having documented by a test, to avoid inadvertently changing it, and previously no such test existed.)