Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parser crashes when input contains duplicate schemas at root level #2301

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

gaborbernat
Copy link
Collaborator

@gaborbernat gaborbernat commented Feb 3, 2025

Resolves #2300

@@ -33,6 +33,7 @@ commands =
--cov-report xml:{env:COVERAGE_XML:{work_dir}{/}coverage.{env_name}.xml} \
--junitxml {work_dir}{/}junit.{env_name}.xml \
tests}
diff-cover --compare-branch {env:DIFF_AGAINST:origin/main} {env:COVERAGE_XML:{work_dir}{/}coverage.{env_name}.xml}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this in my original tox PR somehow 🤦

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (48abf0e) to head (2d7a660).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2301   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files          38       38           
  Lines        4314     4317    +3     
  Branches      841      844    +3     
=======================================
+ Hits         4219     4222    +3     
  Misses         64       64           
  Partials       31       31           
Flag Coverage Δ
unittests 97.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #2301 will not alter performance

Comparing gaborbernat:fix-gen (2d7a660) with main (48abf0e)

Summary

✅ 31 untouched benchmarks

@gaborbernat
Copy link
Collaborator Author

gaborbernat commented Feb 4, 2025

@koxudaxi can we merge this and cut a release, please? 😊 (for releasing I've switched the release action to use https://docs.pypi.org/trusted-publishers/adding-a-publisher/, so you'll need to setup that if you haven't). Thanks!

My offer to become co-maintainer and help out with the project, still stands 😊

@koxudaxi koxudaxi merged commit 8158143 into koxudaxi:main Feb 4, 2025
37 checks passed
@gaborbernat gaborbernat deleted the fix-gen branch February 4, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate removal causes object has no attribute 'replace_reference'
2 participants