Repository navigation
ci: run the tutorials on PyTorch 2.15 and fix the ADA notebook - #120
Merged
Merged
Conversation
Pin torch 2.15.0 and torchvision 0.29.2 in both jobs of build.yml and raise the requirements.txt floors to match. The ADA preset notebook stopped running after kornia#6305, which makes the default augmentation stack raise on non-square images because its RandomRotation90 can turn them by 90 degrees. Crop the panda to its central square, and give the 64 x 128 training cell an explicit stack that matches the defaults but only turns by 180 degrees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This moves the tutorials CI to PyTorch 2.15 and fixes the notebook that turns kornia's scheduled
tutorialsjob red.PyTorch 2.15
.github/workflows/build.yml:pytorch-versionis2.15.0andtorchvision-versionis0.29.2in both jobs. There is no torchvision 0.30 yet; 0.29.2 is the latest release and requirestorch>=2.14.0.requirements.txt:torch>=2.15.0andtorchvision>=0.29.2.adaptive_discriminator_augmentation_preset.ipynbkornia/kornia#6305 deliberately makes the default
AdaptiveDiscriminatorAugmentationstack raise on non-square images, becauseRandomRotation90(times=(0, 3))can turn them by 90 degrees, and a kornia test pins that behaviour. So the notebook is what needs to change:RandomRotation90(times=(2, 2), p=0.5)only makes half turns. A bullet explains this.The scheduled job checks out this repo's default branch, so the fix takes effect on kornia's next scheduled run after this merges, with no kornia change.
What did you check?
Not verified: this workflow itself, including
kornia/workflows' env action on 2.15. This PR's CI is the first run. The other 37 notebooks were not rerun after the fix, because the fix only touches this one notebook.Which part was done by a human, if any?
None. @ducha-aiki asked to fix the red scheduled run, asked to update the tutorials to torch 2.15, and approved opening this PR; AI did the rest. No human has reviewed the diff yet.
Written by Claude (Opus 5.5) on behalf of @ducha-aiki