✨ Add fileMounts to attach Secrets/ConfigMaps as files - #195
Open
djzager wants to merge 1 commit into
Open
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AgentRun and AgentWorkflowRun gain a fileMounts field: the file-shaped sibling of envFrom, for config or credentials a skill or tool reads from a path (a config file, a service-account JSON) rather than from an environment variable. Each mount names exactly one Secret or ConfigMap (CEL-enforced), mounted read-only, and supports whole-object directory mounts, key selection (items), and single-file mounts (subPath). The controller wires the mounts into the Sandbox pod's existing volume plumbing and rejects, before creating the Sandbox, any mountPath that lands on, under, or above a controller-managed mount — failing the run terminally with InvalidFileMounts. The reserved mount paths are centralized in one set (reservedMountPaths), and /workspace and /tmp are promoted from string literals to named constants so the mount sites and the collision guard cannot drift. Signed-off-by: David Zager <david.j.zager@gmail.com>
djzager
force-pushed
the
feature/filemounts-secret-configmap-as-files
branch
from
August 27, 2026 19:26
5ea741b to
d11dadf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentRun and AgentWorkflowRun gain a fileMounts field: the file-shaped sibling of envFrom, for config or credentials a skill or tool reads from a path (a config file, a service-account JSON) rather than from an environment variable. Each mount names exactly one Secret or ConfigMap (CEL-enforced), mounted read-only, and supports whole-object directory mounts, key selection (items), and single-file mounts (subPath).
The controller wires the mounts into the Sandbox pod's existing volume plumbing and rejects, before creating the Sandbox, any mountPath that lands on, under, or above a controller-managed mount — failing the run terminally with InvalidFileMounts. The reserved mount paths are centralized in one set (reservedMountPaths), and /workspace and /tmp are promoted from string literals to named constants so the mount sites and the collision guard cannot drift.