memory cleanup #169
Merged
memory cleanup #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heythisisnate
force-pushed
the
mem-cleanup
branch
2 times, most recently
from
a42817e to
f89a334
Compare
heythisisnate
force-pushed
the
mem-cleanup
branch
from
f89a334 to
8296ff7
Compare
heythisisnate
force-pushed
the
mem-cleanup
branch
from
f7f0d97 to
672c3b4
Compare
This allows the Lua complier to execute the zoneToPin function directly from flash with no RAM used for the previous table.
* Allows for modules to access mqtt methods for situations where it may be required. * When settings are pushed the mqtt client will now be disconnected before writing the new settings, which is now handled in the "offline" method of the mqtt client. This allows for larger payloads by freeing memory before processing, preventing "out of RAM" errors.
heythisisnate
commented
Aug 20, 2022
| if zone == 5 or zone == '5' then return 7 end | ||
| if zone == 6 or zone == '6' then return 9 end | ||
| if zone == "out" then return 8 end | ||
| end |
| local request = require("httpd_req")(payload) | ||
| local response = require("httpd_res")() | ||
| request = require("httpd_req")(payload) | ||
| response = require("httpd_res")() |
There was a problem hiding this comment.
curious what does removing the local declaration actually do?
There was a problem hiding this comment.
This makes the variables global so they can be accessed in the offline callback before being garbage collected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.