Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXUI-278): fixed breadcrumbs for create release and create sec… #87

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rakshett
Copy link
Contributor

@rakshett rakshett commented Jan 17, 2025

Fixes

https://issues.redhat.com/browse/KFLUXUI-278

Description

Updated Broken Breadcrumbs links with updating the user's workspace

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (3ae7eee) to head (72bd76c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   80.09%   80.10%           
=======================================
  Files         570      570           
  Lines       21476    21483    +7     
  Branches     5326     5326           
=======================================
+ Hits        17202    17209    +7     
- Misses       4249     4250    +1     
+ Partials       25       24    -1     
Flag Coverage Δ
unittests 80.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rakshett rakshett closed this Jan 21, 2025
@rakshett rakshett reopened this Jan 21, 2025
@rakshett rakshett closed this Jan 21, 2025
@rakshett rakshett reopened this Jan 21, 2025
@StanislavJochman
Copy link
Contributor

LGTM

@testcara
Copy link
Contributor

testcara commented Jan 22, 2025

It would be better if you can improve the Fixes and Description of the PR.
The patch is LTGM

@testcara
Copy link
Contributor

/retest

@sahil143
Copy link
Collaborator

/retest

@abhinandan13jan
Copy link
Contributor

@rakshett CodeCov patch needs to be increased

@rakshett
Copy link
Contributor Author

rakshett commented Jan 28, 2025

@rakshett CodeCov patch needs to be increased

@abhinandan13jan Fixed. Please valdiate

@rakshett
Copy link
Contributor Author

rakshett commented Jan 28, 2025

It would be better if you can improve the Fixes and Description of the PR. The patch is LTGM

@testcara Updated description, Please validate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants