Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-266): Replaced GitHub mentions with Git #71

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

janaki29
Copy link
Contributor

@janaki29 janaki29 commented Jan 10, 2025

https://issues.redhat.com/browse/KFLUXUI-266

Add/Edit Release Plan Page:
image

Add/Edit Integration Test Page:
image

Integration Tests List:
image

Replace GitHub mentions with Git in:

  1. Add and edit release plan pages.
  2. Add and edit integration test pages.
  3. Page that lists releases(NA)

@sahil143
Copy link
Collaborator

/ok-to-test

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (1b04567) to head (208cb64).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files         569      569           
  Lines       21391    21391           
  Branches     5299     5291    -8     
=======================================
  Hits        17146    17146           
  Misses       4220     4220           
  Partials       25       25           
Flag Coverage Δ
unittests 80.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcin-michal
Copy link
Contributor

LGTM

@sahil143
Copy link
Collaborator

/ok-to-test

@janaki29 janaki29 changed the title Replaced GitHub mentions with Git feat(KFLUXUI-266): Replaced GitHub mentions with Git Jan 13, 2025
Copy link
Contributor

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replace the github mention in the variable names, otherwise LGTM

e2e-tests/support/pages/tabs/IntegrationTestsTabPage.ts Outdated Show resolved Hide resolved
e2e-tests/support/pages/tabs/IntegrationTestsTabPage.ts Outdated Show resolved Hide resolved
@janaki29 janaki29 requested a review from JoaoPedroPP January 13, 2025 17:34
@StanislavJochman
Copy link
Contributor

LGTM - please make sure to rebase it after merging #72 so it will be ok and everything will be changed.

@janaki29
Copy link
Contributor Author

LGTM - please make sure to rebase it after merging #72 so it will be ok and everything will be changed.

sure

@sahil143
Copy link
Collaborator

/test

@sahil143 sahil143 merged commit c491150 into konflux-ci:main Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants