fix(KFLUXBUGS-1342): add existing secret in the components secret form

[JoaoPedroPP]

Fixes

KFLUXBUGS-1342

Description

When onboarding a new component and adding a build time secret, the dialog cannot find an existing secret in the workspace.

[codecov]

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (4609b37) to head (0c62824).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/components/Secrets/SecretForm.tsx	80.00%	5 Missing ⚠️
src/components/Secrets/SecretModalLauncher.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   80.11%   80.09%   -0.02%     
==========================================
  Files         570      570              
  Lines       21452    21476      +24     
  Branches     5050     5062      +12     
==========================================
+ Hits        17187    17202      +15     
- Misses       4241     4250       +9     
  Partials       24       24              

Flag	Coverage Δ
unittests	80.09% <90.32%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[StanislavJochman]

Let me know when you will have it ready. Will pull it and try it out.

[sahil143]

/retest

[JoaoPedroPP]

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (1b04567) to head (b8dafd3).

Files with missing lines Patch % Lines
src/components/Secrets/SecretForm.tsx 80.00% 5 Missing ⚠️
src/components/Secrets/SecretModalLauncher.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

I believe this can be safely ignored

[marcin-michal]

LGTM. Just wondering, is the smyk-secret always supposed to be an option? When adding a build secret to a component, it shows up as existing, even though I don't have it in the secrets list.

[marcin-michal]

IMO a little confusing when the newSecrets property has the type ExistingSecret

[JoaoPedroPP]

Nice catch!
Changed to BuildTimeSecret

[JoaoPedroPP]

LGTM. Just wondering, is the smyk-secret always supposed to be an option? When adding a build secret to a component, it shows up as existing, even though I don't have it in the secrets list.

The snyk-secret is special case that the user should always have the option to record, if it doesn't exist, or to use it

[StanislavJochman]

LGTM

[testcara]

LGTM