Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cookie.httpOnly in reset #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jiasm
Copy link

@Jiasm Jiasm commented Jan 21, 2025

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

When a user sets httpOnly: false, the default behavior of reset might result in document.cookie not being updated on Safari browsers. This can lead to a mismatch between the cookie information in the application and the cookies obtained by the frontend. To ensure consistency in cookie data, I recommend referencing the behavior of cookie.httpOnly during the reset process.

Alternatively, should we consider using all configuration options available with cookies here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant