Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 4, 2026 00:18
@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.40%. Comparing base (0433589) to head (09a4d4e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cli.ts 94.44% 0 Missing and 1 partial ⚠️
src/format.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   93.40%   93.40%   -0.01%     
==========================================
  Files          26       26              
  Lines        5167     5197      +30     
  Branches     1140     1148       +8     
==========================================
+ Hits         4826     4854      +28     
+ Misses        306      305       -1     
- Partials       35       38       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a dual package hazard allowlist feature that allows users to suppress dual package hazard diagnostics for specific packages. The feature is useful when intentional dual package patterns are known to be safe in the user's context.

Key changes:

  • Added dualPackageHazardAllowlist option accepting an array of package names to exclude from dual package hazard checks
  • CLI flag --dual-package-hazard-allowlist accepts comma-separated package names or multiple invocations
  • Package names are automatically trimmed and empty values filtered out
  • Version bumped from 1.5.0-rc.0 to 1.5.0

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/types.ts Added dualPackageHazardAllowlist?: string[] option to ModuleOptions type
src/module.ts Added default empty array for allowlist and passed it to diagnostics function
src/format.ts Implemented normalizeAllowlist function to trim/filter entries and added allowlist filtering in dualPackageHazardDiagnostics
src/cli.ts Added CLI flag parsing with parseAllowlist function that handles comma-separated values and multiple invocations
test/module.ts Added test verifying allowlist suppresses hazards with whitespace-padded package name
test/cli.ts Added CLI test verifying allowlist flag works with whitespace-padded package name
README.md Documented the new dualPackageHazardAllowlist option with type and usage details
package.json Version bumped from 1.5.0-rc.0 to 1.5.0
package-lock.json Version synchronized with package.json

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit d5d2642 into main Jan 4, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 4, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants