Keep node_modules generated by the npm inside the image#94
Open
illia-bobyr wants to merge 1 commit into
Open
Conversation
`./backend:/app` volume mapping for the `backend` image will shadow the `node_modules` folder that is populated by the `npm install` executed when the `backend` image is prepared. This creates a rather confusing behavior, when the image setup log shows that the packages are installed, and yet, the next step of running `nodemon` or `ts-node` fails. I guess if `node_modules` is populated in the original tree, this issue is obscured. But it seems broken, and will break anyone trying to run `./localdev.sh up` after a `git clone`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./backend:/appvolume mapping for thebackendimage will shadow thenode_modulesfolder that is populated by thenpm installexecuted when thebackendimage is prepared.This creates a rather confusing behavior, when the image setup log shows that the packages are installed, and yet, the next step of running
nodemonorts-nodefails.I guess if
node_modulesis populated in the original tree, this issue is obscured. But it seems broken, and will break anyone trying to run./localdev.sh upafter agit clone.