Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder refactoring #16

Open
wants to merge 10 commits into
base: folder-refactoring
Choose a base branch
from
Open

Folder refactoring #16

wants to merge 10 commits into from

Conversation

igauravsehrawat
Copy link
Contributor

Added a service folder.
I have a doubt on where to put it. I put it, closest to its use.

@ashokdey
Copy link
Member

ashokdey commented Sep 13, 2018 •
edited
Loading

@igauravsehrawat : services folder has to be in the root of app folder. Please revise it.
Also inside app/helpers/sendResponse.js can you modify line 12 to send success for HTTP code 3XX?

Thanks!

@igauravsehrawat
Copy link
Contributor Author

services folder is outside, should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJSGirl TheJSGirl Awaiting requested review from TheJSGirl

@ankitdutta318 ankitdutta318 Awaiting requested review from ankitdutta318

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igauravsehrawat @ashokdey