Skip to content

git/gitlab: enable SSL verification for project webhooks#3735

Open
Vi-shub wants to merge 1 commit into
knative:mainfrom
Vi-shub:git/gitlab-webhook-ssl-verify-default
Open

git/gitlab: enable SSL verification for project webhooks#3735
Vi-shub wants to merge 1 commit into
knative:mainfrom
Vi-shub:git/gitlab-webhook-ssl-verify-default

Conversation

@Vi-shub
Copy link
Copy Markdown

@Vi-shub Vi-shub commented May 14, 2026

Changes

  • Enable the SSL verification

/kind gitlab

Fixes #3731

Signed-off-by: Vi-shub <smsharma3121@gmail.com>
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

@Vi-shub: The label(s) kind/gitlab cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • Enable the SSL verification

/kind gitlab

Fixes #3731

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 14, 2026 20:10
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vi-shub
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label May 14, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

Hi @Vi-shub. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label May 14, 2026
@Vi-shub
Copy link
Copy Markdown
Author

Vi-shub commented May 15, 2026

@matejvasek @gauron99 can you review this please. Thankyou for your time :)

@matejvasek
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels May 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.98%. Comparing base (c28a5dc) to head (7d6c1c1).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/git/gitlab/gitlab.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3735      +/-   ##
==========================================
+ Coverage   56.18%   56.98%   +0.80%     
==========================================
  Files         181      181              
  Lines       20928    21116     +188     
==========================================
+ Hits        11758    12033     +275     
+ Misses       8007     7861     -146     
- Partials     1163     1222      +59     
Flag Coverage Δ
e2e 35.81% <0.00%> (-0.33%) ⬇️
e2e go 32.42% <0.00%> (?)
e2e node 28.20% <0.00%> (?)
e2e python 32.80% <0.00%> (?)
e2e quarkus 28.34% <0.00%> (?)
e2e rust 27.75% <0.00%> (-0.27%) ⬇️
e2e springboot 26.24% <0.00%> (-0.27%) ⬇️
e2e typescript 28.30% <0.00%> (-0.29%) ⬇️
e2e-config-ci 17.70% <0.00%> (?)
integration 17.28% <0.00%> (-0.19%) ⬇️
unit macos-14 45.05% <0.00%> (+0.06%) ⬆️
unit macos-latest 45.05% <0.00%> (+0.06%) ⬆️
unit ubuntu-24.04-arm 45.32% <0.00%> (+0.16%) ⬆️
unit ubuntu-latest 46.00% <0.00%> (+0.16%) ⬆️
unit windows-latest 45.09% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git/gitlab: default project webhooks to SSL verification when creating hooks

2 participants