Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update deprecated function to fix failing CI-check #2701

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Feb 18, 2025

Signed-off-by: David Fridrich <[email protected]>
@knative-prow knative-prow bot requested review from rhuss and vyasgun February 18, 2025 20:19
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@gauron99 gauron99 changed the title fix: Update depracted function to fix failing CI-check fix: Update deprecated function to fix failing CI-check Feb 18, 2025
@gauron99 gauron99 requested review from matejvasek and lkingland and removed request for rhuss and vyasgun February 18, 2025 20:19
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.31%. Comparing base (67d17c2) to head (c9a857b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/git/github/github.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
+ Coverage   64.05%   65.31%   +1.25%     
==========================================
  Files         131      131              
  Lines       15583    15583              
==========================================
+ Hits         9982    10178     +196     
+ Misses       4651     4417     -234     
- Partials      950      988      +38     
Flag Coverage Δ
e2e-test 35.84% <0.00%> (ø)
e2e-test-oncluster 34.22% <0.00%> (+1.42%) ⬆️
e2e-test-oncluster-runtime 28.55% <0.00%> (?)
e2e-test-runtime-go 26.46% <0.00%> (?)
e2e-test-runtime-node 25.86% <0.00%> (?)
e2e-test-runtime-python 25.86% <0.00%> (?)
e2e-test-runtime-quarkus 26.01% <0.00%> (?)
e2e-test-runtime-rust 24.96% <0.00%> (?)
e2e-test-runtime-springboot 24.98% <0.00%> (?)
e2e-test-runtime-typescript 25.97% <0.00%> (?)
integration-tests 51.95% <0.00%> (+2.27%) ⬆️
unit-tests 50.90% <0.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauron99
Copy link
Contributor Author

@matejvasek @lkingland PTAL

@gauron99
Copy link
Contributor Author

@matzew PTAL

@gauron99 gauron99 requested a review from matzew February 19, 2025 09:09
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
Copy link

knative-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

hmm tide says this is in merge pool.

@knative-prow knative-prow bot merged commit d7f4b83 into knative:main Feb 19, 2025
39 checks passed
@gauron99 gauron99 deleted the ci-check-fail-2025-02-18 branch February 19, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants