Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dep on golang.org/x/exp #2695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot requested review from rhuss and vyasgun February 17, 2025 14:12
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for rhuss and vyasgun February 17, 2025 14:12
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.30%. Comparing base (bc6fad7) to head (9e6f003).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
+ Coverage   64.05%   65.30%   +1.24%     
==========================================
  Files         131      131              
  Lines       15583    15583              
==========================================
+ Hits         9982    10176     +194     
+ Misses       4651     4420     -231     
- Partials      950      987      +37     
Flag Coverage Δ
e2e-test 35.84% <0.00%> (-0.05%) ⬇️
e2e-test-oncluster 34.20% <0.00%> (+1.41%) ⬆️
e2e-test-oncluster-runtime 28.55% <0.00%> (?)
e2e-test-runtime-node 25.86% <0.00%> (?)
e2e-test-runtime-python 25.86% <0.00%> (?)
e2e-test-runtime-quarkus 26.01% <0.00%> (?)
e2e-test-runtime-rust 24.92% <0.00%> (?)
e2e-test-runtime-springboot 25.00% <0.00%> (?)
e2e-test-runtime-typescript 25.97% <0.00%> (?)
integration-tests 51.97% <100.00%> (+2.36%) ⬆️
unit-tests 50.90% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2025
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
Copy link

knative-prow bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants