feat: remote storage class #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
+ Coverage 64.05% 65.31% +1.26%
==========================================
Files 131 131
Lines 15583 15591 +8
==========================================
+ Hits 9982 10184 +202
+ Misses 4651 4418 -233
- Partials 950 989 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lkingland
force-pushed
the
storage-class
branch
from
a43359a to
afce0ea
Compare
lkingland
force-pushed
the
storage-class
branch
from
afce0ea to
d57d3ec
Compare
knative-prow
bot
removed
the
do-not-merge/work-in-progress
gauron99
approved these changes
Feb 18, 2025
| @@ -141,6 +141,10 @@ type BuildSpec struct { | |||
| // when using deployment and remote build process (only relevant when Remote is true). | |||
| PVCSize string `yaml:"pvcSize,omitempty"` | |||
|
|
|||
| // RemoteStorageClass specifies the storage class to use for the volume used | |||
| // on-cluster during when built remotely. | |||
There was a problem hiding this comment.
Suggested change
| // on-cluster during when built remotely. | |
| // on-cluster when built remotely. |
i guess this is a left-over word?
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lkingland
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the --remote-storage-class flag which allows specifying a storage class name for the PVC used for on-cluster builds.
/kind enhancement
Release Note