-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: mount propagation documentation in feature flags #6223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome @elijah-rou! It looks like this is your first PR to knative/docs 🎉 |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we undo the formatting that's not related to the feature flag you're adding?
@@ -65,7 +65,7 @@ GA stage | |||
An extension surfaces details of a specific Knative implementation, or features of the underlying environment. | |||
|
|||
!!! note | |||
Extensions are never included in the core Knative API due to their lack of portability. | |||
Extensions are never included in the core Knative API due to their lack of portability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prior indent is intentional - otherwise the note block doesn't render properly
@@ -92,7 +92,7 @@ Only one container can handle requests, so exactly one container must have a `po | |||
```yaml | |||
apiVersion: serving.knative.dev/v1 | |||
kind: Service | |||
... | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't want this change - we're just using ...
to elide the metadata
|
||
This flag allows specifying probes (readiness/liveness) for multiple containers in a Knative Service spec. | ||
Please use this feature flag in combination with [multiple containers](#multiple-containers) above. | ||
|
||
```yaml | ||
apiVersion: serving.knative.dev/v1 | ||
kind: Service | ||
... | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise above
### Kubernetes Volume Mount Propagation | ||
|
||
- **Type**: Extension | ||
- **ConfigMap keys:** `kubernetes.podspec-mount-propagation` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **ConfigMap keys:** `kubernetes.podspec-mount-propagation` | |
- **ConfigMap keys:** `kubernetes.podspec-volumes-mount-propagation` |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elijah-rou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds mountPropagation to the features/extensions page. For knative/serving#15758