Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artists metadata #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

AldeToro
Copy link

Fix for artists names in metadata to resolve issue #115

Modified filename to have album's artist name instead
Modified ID3v1 artist metadata for album's artist (main artist) instead of song's ART_NAME value
Modified ID3v2 album's artist metadata for album's artist (main artist) instead of song's ART_NAME value
Modified ID3v2 artists metadata for a concatenation of all artists of the song

(It's my first pull request ever, yay \o/)

…adata, list of artists in artists metadata
@kmille
Copy link
Owner

kmille commented Nov 24, 2024

Can you give me a song where the PR fixes the problem. I also had problems in the past (#110)

@AldeToro
Copy link
Author

You can use the one used in example in the issue #115
Scooter - My Gabber / https://deezer.page.link/Hr4uE6ewKMLxkMaR7

@AldeToro
Copy link
Author

I also changed the used deezer URL from german to english because some artists names were translated to german

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants