Skip to content

feat(slider): add clickable link in subTitle and key for CNCF image switch #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yashisrani
Copy link
Contributor

  • Made "click here for more Details" text a clickable link
  • Added key prop to enable quick switching of CNCF image based on dark/light mode

Signed-off-by: GitHub Action <[email protected]>
Copy link

netlify bot commented Aug 15, 2025

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 7c8d3ad
🔍 Latest deploy log https://app.netlify.com/projects/kmesh-net/deploys/689f184b4acb4400085a1c59
😎 Deploy Preview https://deploy-preview-222--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nlgwcy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yashisrani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user interface by making the 'more details' text in the slider component a clickable link, directing users to relevant documentation. Additionally, it improves the dynamic rendering of the CNCF logo by adding a 'key' prop, ensuring correct image display when switching between dark and light modes.

Highlights

  • Clickable Link in Slider Subtitle: The text 'click here for more Details' within the slider component has been converted into a clickable hyperlink. This provides users with direct navigation to the 'kmesh.net/docs/welcome' page for more information.
  • CNCF Image Switching with Key Prop: A 'key' prop has been added to the CNCF logo image. This ensures that the image component properly re-renders and switches between the dark and light mode versions of the logo when the application's color mode changes, improving UI reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two valuable enhancements. It makes the subtitle in the homepage slider a clickable link to the documentation and ensures the CNCF logo correctly switches between dark and light modes. My review includes a suggestion to improve the new link by adding necessary security and usability attributes (target, rel) and moving inline styles to a stylesheet for better maintainability. Overall, these are good changes.

Comment on lines +26 to +31
<a
href="https://kmesh.net/docs/welcome"
style={{ color: 'inherit', textDecoration: 'underline' }}
>
<Translate>Click here for more Details</Translate>
</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is an external link. For security and user experience, it should open in a new tab. Please add target="_blank" and rel="noopener noreferrer".

Additionally, for better maintainability, it's recommended to move inline styles to a stylesheet. I've replaced the style prop with a className. Please add the corresponding styles to src/components/slider/index.scss.

For example:

.subtitle-link {
  color: inherit;
  text-decoration: underline;
}
      <a
        href="https://kmesh.net/docs/welcome"
        className="subtitle-link"
        target="_blank"
        rel="noopener noreferrer"
      >
        <Translate>Click here for more Details</Translate>
      </a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants