Skip to content

feat(KLEF-117): Clean up plugin code/decouple code#22

Merged
isaacwallace123 merged 3 commits intomainfrom
feat/KLEF-117-Clean_Up_Plugin_Code/Decouple_Code
Apr 2, 2026
Merged

feat(KLEF-117): Clean up plugin code/decouple code#22
isaacwallace123 merged 3 commits intomainfrom
feat/KLEF-117-Clean_Up_Plugin_Code/Decouple_Code

Conversation

@NathanRoos
Copy link
Copy Markdown
Contributor

Pull Request

Summary

go.work referenced ../plugin-sdk-go as a local path which doesn't exist
in CI or Docker, causing builds to break on any machine other than the original
developer's. The published module version is already pinned in go.mod.

Related Issues

Closes #


Changes

What's Included

  • Removed ../plugin-sdk-go local path entry from go.work
  • Platform now uses the published github.com/kleffio/plugin-sdk module
    version from go.mod as intended

What's Not Included


Testing

How Was This Tested?

  • Tested locally with docker compose up
  • Verified API builds and starts successfully

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

If yes, describe the impact and any required migration steps:


Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

If any box is checked, describe the security impact and any mitigations applied:


Documentation

Does this PR require documentation updates?

  • Yes
  • No

If yes, check all that apply:

  • README.md
  • ARCHITECTURE.md
  • API reference
  • Architecture diagrams (C4 / DDD)
  • /docs

UI/UX (If Applicable)

  • Includes new components or views
  • Changes styles or theme tokens
  • Responsive behavior verified
  • Requires design approval

Screenshots or recordings:


Pre-Merge Checklist

  • PR title follows semantic format (feat:, fix:, chore:, docs:, refactor:, test:)
  • All CI checks passing
  • Code follows project style guidelines
  • No debug logs or commented-out code left in
  • Dependencies reviewed (no unnecessary additions)
  • No sensitive information included

Reviewer Notes

NathanRoos and others added 3 commits March 31, 2026 22:00
…plugins API

Plugin domain now carries a FrontendURL field. The persistence store reads and writes it, the HTTP handler exposes it in the installed plugins response, and the manager handles frontend-only plugins (no gRPC addr) without treating them as unhealthy.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@NathanRoos NathanRoos self-assigned this Apr 1, 2026
@NathanRoos NathanRoos added the enhancement New feature or request label Apr 1, 2026
@github-actions github-actions bot added the feature New feature or enhancement label Apr 1, 2026
@NathanRoos NathanRoos changed the title Feat/klef 117 clean up plugin code/decouple code feat(KLEF-117): Clean up plugin code/decouple code Apr 1, 2026
@isaacwallace123 isaacwallace123 merged commit a8b7143 into main Apr 2, 2026
11 of 12 checks passed
@isaacwallace123 isaacwallace123 deleted the feat/KLEF-117-Clean_Up_Plugin_Code/Decouple_Code branch April 2, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants