Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Klarna SignIn Implementation #299

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Klarna SignIn Implementation #299

wants to merge 38 commits into from

Conversation

jorgepalac1o
Copy link
Contributor

No description provided.

@jorgepalac1o
MSDK-892 Added KlarnaSignIn module specification
f617a56
@jorgepalac1o
MSDK-892 Added SignIn screen to the RN test app
8031d7c
@jorgepalac1o
MSDK-892 Added KlarnaSignInManager native iOS class and renamed the m…
cde4a48 
…odule
@jorgepalac1o
MSDK-892 Added module name to match turbo generated one, also impleme…
f3d9261 
…nted new protocols in whe manager class
@jorgepalac1o
MSDK-892 Added new architecture validations to make turbo native modu…
5b151b7 
…le compatible with old arch
@jorgepalac1o
MSDK-892 Fixed old architecture build errors
85c9cf1
@jorgepalac1o
MSDK-892 KlarnaSignInEventsHandler class created to centralize common…
938c60f 
… code between old and new architecture
@jorgepalac1o
MSDK-892 Fixed new architecture build errors. Library module hidden b…
b55bf32 
…ehind public KlarnaSignIn class now
@jorgepalac1o
MSDK-892 Added KlarnaSignInManager native module for Android in new a…
0dffaba 
…rchitecture
@jorgepalac1o
MSDK-892 Fixed sign in sdk initialization by running the init from th…
47b200a 
…e main thread.
@jorgepalac1o
MSDK-892 Moved KlarnaSignInManager to newArch folder.
423516e
@jorgepalac1o
MSDK-892 Added old arch klarna sign in spec and implementation. Renam…
622e045 
…ed the files to keep the standard accordingly
@jorgepalac1o
MSDK-892 Renamed implementation in android new arch to use the module…
8b519e8 
… spec and instance
@jorgepalac1o
MSDK-892 Renamed implementation in ios on both archs to use the modul…
ba03e47 
…e spec and implementation to avoid code repetition
@jorgepalac1o
MSDK-892 Code formatting after testing new arch
a7f1a5f
@jorgepalac1o
MSDK-892 Added KlarnaRedirectReceiverActivity to the test app manifes…
d8302e0 
…t. Updated the return url value in the signIn screen
@jorgepalac1o
MSDK-892 Added new intent to manifest and removed validations from si…
5c1ebaa 
…gnInScreen
@jorgepalac1o
MSDK-892 Fixed serialization of events in android signIn module, also…
e724471 
… updated test app events display
@jorgepalac1o
MSDK-892 Renamed manager to module to keep it consistent, updated wit…
88aaa3b 
…h latest changes to return the right parameter values after completing signIn
@jorgepalac1o jorgepalac1o requested a review from a team as a code owner March 5, 2025 10:20
NMGuner
NMGuner reviewed Mar 11, 2025
View reviewed changes
NMGuner
NMGuner reviewed Mar 11, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NMGuner NMGuner NMGuner left review comments

@mahmoudjafarinejad mahmoudjafarinejad mahmoudjafarinejad left review comments

@MasoudFallahpourbaee MasoudFallahpourbaee MasoudFallahpourbaee left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgepalac1o @NMGuner @mahmoudjafarinejad @MasoudFallahpourbaee