Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for BUG: failing test_hierharchy_arraylist with jdk>=21 #736 #741

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cmacdonald
Copy link
Contributor

As reported by @h-vetinari the test test_hierharchy_arraylist made assumptions about the hierarchy of objects that are no longer relevant. This softens the test so it works on jdks 21-23.

Before merging, we need to agree on the JDK versions we should be testing. Windows termurin seems to only have upto 18?

@tshirtman
Copy link
Member

As far as i can tell, the change should work on the previous versions as well, as it accepts the result we used to enforce. I'm not sure it should be conditional on changing JDK versions tested in CI. Dropping old versions is always a tradeoff, and it can be acceptable, even if some software still didn't upgrade their support.

looking at
https://endoflife.date/oracle-jdk
https://endoflife.date/redhat-build-of-openjdk
and https://endoflife.date/microsoft-build-of-openjdk

doesn't seem to give any consistent indication to what should be supported…

@h-vetinari
Copy link

Thanks for working on a fix! This will fix #736

@h-vetinari
Copy link

doesn't seem to give any consistent indication to what should be supported…

Plus there are alternative implementations of the java runtime; a good overview of the timelines can be found at wikipedia. Of course, pyjnius could choose not to support all versions anymore, many projects in the ecosystem have dropped Java 8 already, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants