Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Remove fields when duplicating a document #185

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[3.x] Remove fields when duplicating a document #185

merged 2 commits into from
Jul 16, 2020

Conversation

Erikmitk
Copy link
Member

This PR removes the date issued, DOI and PPN from a duplicated document.

I added helper functions to access the fields in the mods-xml. I'm only uncertain if the queries are stable enough. I guess they are for our purposes?

This closes #184.

@Erikmitk Erikmitk requested a review from claussni July 15, 2020 10:10
@Erikmitk Erikmitk changed the title Remove fields when duplicating a document [3.x] Remove fields when duplicating a document Jul 15, 2020
@claussni claussni self-assigned this Jul 16, 2020
claussni
claussni approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@claussni claussni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will rework these XPath dependent helper functions and replace them with MODS agnostic data handling. For now it is correct to put them together with the other helpers.

@claussni claussni linked an issue Jul 16, 2020 that may be closed by this pull request
Unreasonable copying of fields when duplicating a document #184
Closed
@claussni claussni merged commit d25c265 into kitodo:3.x Jul 16, 2020
@Erikmitk Erikmitk deleted the feature/improve_duplication branch November 2, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claussni claussni claussni approved these changes

Assignees

@claussni claussni

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unreasonable copying of fields when duplicating a document
2 participants
@Erikmitk @claussni