Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix select overlay issue #172

Merged
merged 5 commits into from
May 28, 2020
Merged

Conversation

Erikmitk
Copy link
Member

@Erikmitk Erikmitk commented May 27, 2020

This PR fixes #171

I added a class to select statements that will have buttons next to them and adjust the styling accordingly. Now it's possible to see clearly if your dealing with a select input element.

Also, the X-glyph is now in the middle and not drunk in the corner!

Before the change:

CleanShot 2020-05-27 at 22 38 02

After the change:

CleanShot 2020-05-27 at 22 38 29

This also effects the backend manager.

Before the change:

CleanShot 2020-05-27 at 22 42 47@2x

After the change:

CleanShot 2020-05-27 at 22 41 51@2x

@Erikmitk Erikmitk changed the title Fix/select overlay [3.x] Fix select overlay issue May 27, 2020
@claussni claussni linked an issue May 28, 2020 that may be closed by this pull request
@claussni claussni merged commit 9d4f132 into kitodo:3.x May 28, 2020
@Erikmitk Erikmitk deleted the fix/select_overlay branch May 28, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] Select elements get overlayed by buttons
2 participants